Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 29 Mar 2013 21:43:15 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12546570.1331811494496.78756.1364593395402@arcas>
In-Reply-To: <JIRA.12546570.1331811494496@arcas>
References: <JIRA.12546570.1331811494496@arcas>
Subject: [jira] [Commented] (HBASE-5583) Master restart on create table with
 splitkeys does not recreate table with all the splitkey regions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617755#comment-13617755 ] 

Ted Yu commented on HBASE-5583:
-------------------------------

{code}
+  public static Set<String> getCreatingTables(ZooKeeperWatcher zkw) throws KeeperException {
{code}
I think getTablesInCreation would be better method name.
{code}
+  public void removeCreateTableStates(final String tableName) {
{code}
Suggest renaming removeCreateTableStates() as removeTableStateForTableInCreation().
{code}
+  private final static Table.State createTableStates[] = { Table.State.CREATING, Table.State.CREATING_TD,
{code}
Why do you use an array instead of a Set ? That way you don't need to iterate through the states in ZKTableReadOnly.isTableState()
{code}
+         List<String> listChildrenNoWatch = ZKUtil.listChildrenNoWatch(this.watcher, this.watcher.tableZNode+"/"+child);
+         for (String string : listChildrenNoWatch) {
+       System.out.println("Status node should be prenet "+string);
+     }
{code}
I guess you would remove the above in the next patch.

For createTableCreationStatusNode():
{code}
+    LOG.info("Created children node "+numberOfChildren);
{code}
If you keep the above log, please add tableName.
{code}
+  public boolean checkAndSetCreatingTableStates(final String tableName) throws KeeperException {
{code}
Remove the trailing 's' in method name.
                
> Master restart on create table with splitkeys does not recreate table with all the splitkey regions
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5583
>                 URL: https://issues.apache.org/jira/browse/HBASE-5583
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.95.0
>
>         Attachments: HBASE-5583_new_1.patch, HBASE-5583_new_2.patch, HBASE-5583_new_4_WIP.patch, HBASE-5583_new_5_WIP_using_tableznode.patch
>
>
> -> Create table using splitkeys
> -> MAster goes down before all regions are added to meta
> -> On master restart the table is again enabled but with less number of regions than specified in splitkeys
> Anyway client will get an exception if i had called sync create table.  But table exists or not check will say table exists. 
> Is this scenario to be handled by client only or can we have some mechanism on the master side for this? Pls suggest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira