hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8209) Improve LoadTest extensibility
Date Thu, 28 Mar 2013 22:07:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616713#comment-13616713
] 

Nick Dimiduk commented on HBASE-8209:
-------------------------------------

Looking at the patch against trunk:

{noformat}
+          for (Result r = null; (r = s.next()) != null;) {
+            byte[] b = r.getValue(HConstants.CATALOG_FAMILY, HConstants.REGIONINFO_QUALIFIER);
+            if (b == null || b.length <= 0) {
+              break;
+            }
{noformat}

Why do you want a {{break}} instead of {{continue}}? Doesn't this drop potential records on
the floor?

Also, your non-standard for-loop control arguments caught me off-guard :)
                
> Improve LoadTest extensibility
> ------------------------------
>
>                 Key: HBASE-8209
>                 URL: https://issues.apache.org/jira/browse/HBASE-8209
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.95.0, 0.96.0, 0.94.7
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>         Attachments: HBASE-8209-0.94.patch, HBASE-8209-trunk.patch
>
>
> This patch rolls up related changes:
> - Allow classes extending TestMiniClusterLoadSequential to override how reader and writer
threads are set up, including extending the reader and writers themselves.
> - Make it so classes extending MultiThreadedWriter can cleanly override how Puts are
constructed.
> - Provide an option for passing in a custom table descriptor to HBaseTestingUtility#createPreSplitLoadTestTable.
>     
> - HBaseTestingUtility#waitUntilAllRegionsAssigned does not check if the region it is
counting belongs to the table created by the test and will not return if it accidentally counts
"too many" regions, for example the regions of the ACL table when security is enabled. (Some
class based on TestMiniClusterLoadSequential may want to enable security.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message