hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8160) HMaster#move doesn't check if master initialized
Date Thu, 21 Mar 2013 14:19:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608960#comment-13608960
] 

Jonathan Hsieh commented on HBASE-8160:
---------------------------------------

The other uses of checkInitialized just wrap with ServiceException (no extra UnknownRegionException
wrapping on init check fails).  Stick to the pattern (and remove comment)?

Other methods have a this structural pattern, consider using it in moveRegion as well?

{code}
ProtoResponse method(ProtoRequest) {
...
 actualMethod()
...
}

retType actualMethod(arg, arg, arg) {
  .. 
  checkInitialized() 
  .. do stuff
} 
{code}



                
> HMaster#move doesn't check if master initialized
> ------------------------------------------------
>
>                 Key: HBASE-8160
>                 URL: https://issues.apache.org/jira/browse/HBASE-8160
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Trivial
>             Fix For: 0.95.0, 0.98.0, 0.94.7
>
>         Attachments: 0.94-8160.patch, trunk-8160.patch
>
>
> Before the master is initialized, if a move request comes in, it could cause the master
to abort, if the region was already in transition before the master started up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message