hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8150) the code that handles RAITE on master in 0.94 should not always use the same plan
Date Mon, 25 Mar 2013 22:13:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613220#comment-13613220
] 

Hadoop QA commented on HBASE-8150:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12575406/HBASE-8150-v0-094.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5001//console

This message is automatically generated.
                
> the code that handles RAITE on master in 0.94 should not always use the same plan
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-8150
>                 URL: https://issues.apache.org/jira/browse/HBASE-8150
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.6
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>             Fix For: 0.94.7
>
>         Attachments: HBASE-8150-v0-094.patch
>
>
> The code in 0.94 AM sets the region plan to point to the same server when retrying the
assignment due to RAITE.
> {code}
> LOG.warn("Failed assignment of "
>             + state.getRegion().getRegionNameAsString()
>             + " to "
>             + plan.getDestination()
>             + ", trying to assign "
>             + (regionAlreadyInTransitionException ? "to the same region server"
>                 + " because of RegionAlreadyInTransitionException;" : "elsewhere instead;
")
>             + "retry=" + i, t);
> {code}
> However, there's no wait time in the loop that retries the assignment, and if region
is being marked failed to open, which may take some time, master can easily exhaust retries
in less than half a second, going to the same server every time and getting the same exception
(unfortunately I no longer have logs); then the region will be stuck.
> Do you think this is worth fixing (for example, by not using the same server here after
a few retries, or by adding timed backoff in such cases)?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message