hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8128) HTable#put improvements
Date Mon, 18 Mar 2013 10:02:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604970#comment-13604970
] 

nkeywal commented on HBASE-8128:
--------------------------------

bq. Sound simple and efficient... Will it be possible to have it for 0.94 too?
The patch should be directly applicable, so I can do it. As you and Lars want.

bq. These classes could do with a general revamp.
Agreed. I'm actually studying this currently.

Committed in trunk and 0.95, thanks for the reviews!
                
> HTable#put improvements
> -----------------------
>
>                 Key: HBASE-8128
>                 URL: https://issues.apache.org/jira/browse/HBASE-8128
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.95.0, 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Trivial
>             Fix For: 0.95.0, 0.96.0
>
>         Attachments: 8128.v1.patch
>
>
> 3 points:
>  - When doing a single put, we're creating an object by calling Arrays.asList
>  - we're doing a size check every 10 put. Not doing it seems simpler, better and allows
to share some code between a single put and a list of puts.
>  - we could call flushCommits on empty write buffer, especially for someone using a lot
of HTable instead of using a pool, as it's called in close().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message