hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8125) HBASE-7435 breaks BuiltInGzipDecompressor on Hadoop < 1.0.x
Date Sun, 17 Mar 2013 02:14:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604478#comment-13604478
] 

Jean-Marc Spaggiari commented on HBASE-8125:
--------------------------------------------

I agree with Ted.

If it was already failing in previous releases, I don't think this should sunk this current
RC.
                
> HBASE-7435 breaks BuiltInGzipDecompressor on Hadoop < 1.0.x
> -----------------------------------------------------------
>
>                 Key: HBASE-8125
>                 URL: https://issues.apache.org/jira/browse/HBASE-8125
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Ted Yu
>             Fix For: 0.94.7
>
>         Attachments: 8125-0.94.txt
>
>
> From some friends of ours at dropbox:
> Index: src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java
> ===================================================================
> --- src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java	(revision 1425723)
> +++ src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java	(working copy)
> @@ -33,6 +33,7 @@
>  import org.apache.hadoop.io.compress.CompressionOutputStream;
>  import org.apache.hadoop.io.compress.Compressor;
>  import org.apache.hadoop.io.compress.Decompressor;
> +import org.apache.hadoop.io.compress.DoNotPool;
>  import org.apache.hadoop.io.compress.GzipCodec;
>  import org.apache.hadoop.io.compress.DefaultCodec;
>  import org.apache.hadoop.util.ReflectionUtils;
> @@ -308,6 +309,9 @@
>      public void returnDecompressor(Decompressor decompressor) {
>        if (decompressor != null) {
>          CodecPool.returnDecompressor(decompressor);
> +        if (decompressor.getClass().isAnnotationPresent(DoNotPool.class)) {
> +          decompressor.end();
> +        }
>        }
>      }
> breaks compatibility with hadoop-0.20.2-cdh3u2. 
> +import org.apache.hadoop.io.compress.DoNotPool;
> does not exist in that version of hadoop.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message