hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8112) Deprecate HTable#batch(final List<? extends Row>)
Date Thu, 14 Mar 2013 22:50:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602860#comment-13602860
] 

Ted Yu commented on HBASE-8112:
-------------------------------

Pardon me for introducing the smiley in the first place.
Here is the complete method signature:
{code}
  public Object[] batch(final List<? extends Row> actions)
     throws InterruptedException, IOException {
{code}
Users may rely on the IOE from this method (just guessing).

Basically we cannot return partial results and keep throwing the IOException at the same time.

Jean-Marc mentioned, on the mailing list, that the method from HTableInterface should be deprecated
(same as my intention).
                
> Deprecate HTable#batch(final List<? extends Row>)
> -------------------------------------------------
>
>                 Key: HBASE-8112
>                 URL: https://issues.apache.org/jira/browse/HBASE-8112
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> This was brought up by Amit's inquiry on mailing list, entitled 'Batch returned value
and exception handling'
> Here is his sample code:
> {code}
> Object[] res = null;
> try {
>   res = table.batch(batch);
> } catch (RetriesExhaustedWithDetailsException retriesExhaustedWithDetailsException) {
>   retriesExhaustedWithDetailsException.printStackTrace();
> }
> if (res == null) {
>   System.out.println("No results - returned null.");
> }
> {code}
> When RetriesExhaustedWithDetailsException was thrown from batch() call, variable res
carried value of null.
> Meaning user wouldn't get partial result along with the exception.
> We should deprecate {code}HTable#batch(final List<? extends Row>){code} and refer
to the following method:
> void batch(final List<?extends Row> actions, final Object[] results) throws IOException,
InterruptedException;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message