hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8067) TestHFileArchiving.testArchiveOnTableDelete sometimes fails
Date Sun, 17 Mar 2013 00:04:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604459#comment-13604459
] 

Ted Yu commented on HBASE-8067:
-------------------------------

Patch looks good.

Looking at CleanerChore#checkAndDelete():
{code}
    for (T cleaner : cleanersChain) {
      if (cleaner.isStopped() || this.stopper.isStopped()) {
        LOG.warn("A file cleaner" + this.getName() + " is stopped, won't delete any file in:"
{code}
Since this.stopper doesn't depend on the loop, I think this.stopper.isStopped() can be lifted
out of the loop.
                
> TestHFileArchiving.testArchiveOnTableDelete sometimes fails
> -----------------------------------------------------------
>
>                 Key: HBASE-8067
>                 URL: https://issues.apache.org/jira/browse/HBASE-8067
>             Project: HBase
>          Issue Type: Bug
>          Components: Admin, master, test
>    Affects Versions: 0.96.0, 0.94.6
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>         Attachments: HBASE-8067-debug.patch, HBASE-8067-v0.patch
>
>
> it seems that testArchiveOnTableDelete() fails because the archiving in DeleteTableHandler
is still in progress when admin.deleteTable() returns.
> {code}
> Error Message
> Archived files are missing some of the store files!
> Stacktrace
> java.lang.AssertionError: Archived files are missing some of the store files!
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.assertTrue(Assert.java:41)
> 	at org.apache.hadoop.hbase.backup.TestHFileArchiving.testArchiveOnTableDelete(TestHFileArchiving.java:262)
> {code}
> (Looking at the problem in a more generic way, we don't have any way to inform the client
when an async operation is completed)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message