hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8036) ProtobufUtil.multi behavior is inconsistent in case of errors
Date Wed, 13 Mar 2013 04:20:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600797#comment-13600797
] 

Hadoop QA commented on HBASE-8036:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12573462/hbase-8036_v4.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified
tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4792//console

This message is automatically generated.
                
> ProtobufUtil.multi behavior is inconsistent in case of errors
> -------------------------------------------------------------
>
>                 Key: HBASE-8036
>                 URL: https://issues.apache.org/jira/browse/HBASE-8036
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0
>            Reporter: Sergey Shelukhin
>            Assignee: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.95.0
>
>         Attachments: hbase-8036_v1.patch, hbase-8036_v2.patch, hbase-8036_v3.patch, hbase-8036_v4.patch
>
>
> ProtobufUtil splits operations by regions and performs multiple client.multi calls. In
case if there are certain errors inside RS, HRegionServer adds the corresponding exceptions
to MultiResponse, PU continues the multi request for other regions, and returns partial failure.

> In case of other errors (for example, region not served exception), the entire multi
operation stops executing, and previous successes and partial results are disregarded.
> ProtobufUtil should probably catch ServiceException separately for each client.multi
call, make it a partial-failure exception for all actions for this region, and also continue
the batch, to make the behavior consistent.
> Alternatively, if we want to avoid continuing the batch in case of some server-wide errors/connection
problems/etc., server should do that for region-specific errors (add exception to results
for each action).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message