hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Latham (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8025) zkcli fails when SERVER_GC_OPTS is enabled
Date Thu, 14 Mar 2013 18:06:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602509#comment-13602509
] 

Dave Latham commented on HBASE-8025:
------------------------------------

This approach works for me, and I like how it means that each command now only appears in
one list in the script, so that when adding a new one only one place needs to be updated.
 The difference is that other client commands that aren't listed here won't pick up the CLIENT_GC_OPTS,
but frankly, I don't think gc logging is very important for client commands.

Another alternative if we don't care about client gc logging is to put include the SERVER_GC_OPTS
directly in the HBASE_REST_OPTS etc in hbase_env.sh.
                
> zkcli fails when SERVER_GC_OPTS is enabled
> ------------------------------------------
>
>                 Key: HBASE-8025
>                 URL: https://issues.apache.org/jira/browse/HBASE-8025
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.4
>            Reporter: Dave Latham
>            Assignee: Dave Latham
>             Fix For: 0.95.0, 0.98.0, 0.94.6
>
>         Attachments: 8025-alt.txt, HBASE-8025-0.94.patch
>
>
> HBASE-7091 added logic to separate GC logging options for some client commands versus
server commands.  It uses a list of known client commands ("shell" "hbck" "hlog" "hfile" "zkcli")
and uses the server GC logging options for all other invocations of bin/hbase.  When zkcli
is invoked, it in turn invokes "hbase org.apache.hadoop.hbase.zookeeper.ZooKeeperMainServerArg"
to gather the server command line arguments, but because org.apache.hadoop.hbase.zookeeper.ZooKeeperMainServerArg
is not on the white list it enables server GC logging, which causes extra output that causes
the zkcli invocation to break.  HBASE-7153 addressed this but the fix only solved the array
syntax - not the white list, so the zkcli command still fails.
> There are many other tools you can invoke that are more likely to "client" than "server"
options. For example, "bin/hbase org.jruby.Main region_mover.rb" or "bin/hbase org.apache.hadoop.hbase.mapreduce.CopyTable"
or "bin/hbase version" or "bin/hbase org.apache.hadoop.hbase.mapreduce.Export". The whitelist
of server commands is shorter and easier to maintain than a whitelist of client commands.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message