hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8002) Make TimeOut Management for Assignment optional in master and regionservers
Date Tue, 05 Mar 2013 20:44:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593888#comment-13593888
] 

nkeywal commented on HBASE-8002:
--------------------------------

bq. is it possible to remove the setting from HConstants and add to where it applies? 
Ok, will do.

bq. where everything is set to null doesn't appear necessary.
I need it because the attributes are final, so must be set on all execution paths. I would
prefer to keep them final, but I can change this if you like.

bq. Precondition instead of assert since we don't usually enable assert when we run and the
timeout checks are infrequent enough it tshouldn't be costly running precondition.
It was more for documentation & unit tests. But ok, will do.


I will commit the patch with point 1) & 3) tomorrow if there is no objection. If you ask
for 2) I will include it.
                
> Make TimeOut Management for Assignment optional in master and regionservers
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-8002
>                 URL: https://issues.apache.org/jira/browse/HBASE-8002
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, master, Region Assignment
>    Affects Versions: 0.95.0, 0.98.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>             Fix For: 0.95.0, 0.98.0
>
>         Attachments: 8002.v3.patch
>
>
> See HBASE-7327

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message