hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7995) Export$Exporter could be replaced with IdentityTableMapper
Date Tue, 12 Mar 2013 02:41:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599626#comment-13599626
] 

Ted Yu commented on HBASE-7995:
-------------------------------

Look good to me.
                
> Export$Exporter could be replaced with IdentityTableMapper
> ----------------------------------------------------------
>
>                 Key: HBASE-7995
>                 URL: https://issues.apache.org/jira/browse/HBASE-7995
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>             Fix For: 0.95.0, 0.98.0
>
>         Attachments: 0001-HBASE-7995-Replace-Export-Exporter-with-IdentityTabl.patch
>
>
> The Mapper implementation in Export looks identical to IdentityTableMapper, except for
the (poor) exception handling. I'd like to consolidate on IdentityTableMapper, but I'm looking
for some historical perspective before doing so (cc [~stack])
> Export$Exporter's map method:
> {code}
>     public void map(ImmutableBytesWritable row, Result value, Context context)
>     throws IOException {
>       try {
>         context.write(row, value);
>       } catch (InterruptedException e) {
>         e.printStackTrace();
>       }
>     }
> {code}
> IdentityTableMapper's map method:
> {code}
>   public void map(ImmutableBytesWritable key, Result value, Context context)
>   throws IOException, InterruptedException {
>     context.write(key, value);
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message