hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7995) Export$Exporter could be replaced with IdentityTableMapper
Date Tue, 12 Mar 2013 02:21:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599613#comment-13599613
] 

Hadoop QA commented on HBASE-7995:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12573225/0001-HBASE-7995-Replace-Export-Exporter-with-IdentityTabl.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestHTableMultiplexer
                  org.apache.hadoop.hbase.util.TestHBaseFsck

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4771//console

This message is automatically generated.
                
> Export$Exporter could be replaced with IdentityTableMapper
> ----------------------------------------------------------
>
>                 Key: HBASE-7995
>                 URL: https://issues.apache.org/jira/browse/HBASE-7995
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>             Fix For: 0.95.0, 0.98.0
>
>         Attachments: 0001-HBASE-7995-Replace-Export-Exporter-with-IdentityTabl.patch
>
>
> The Mapper implementation in Export looks identical to IdentityTableMapper, except for
the (poor) exception handling. I'd like to consolidate on IdentityTableMapper, but I'm looking
for some historical perspective before doing so (cc [~stack])
> Export$Exporter's map method:
> {code}
>     public void map(ImmutableBytesWritable row, Result value, Context context)
>     throws IOException {
>       try {
>         context.write(row, value);
>       } catch (InterruptedException e) {
>         e.printStackTrace();
>       }
>     }
> {code}
> IdentityTableMapper's map method:
> {code}
>   public void map(ImmutableBytesWritable key, Result value, Context context)
>   throws IOException, InterruptedException {
>     context.write(key, value);
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message