hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj Das (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7935) make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations)
Date Tue, 05 Mar 2013 19:46:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593822#comment-13593822
] 

Devaraj Das commented on HBASE-7935:
------------------------------------

Some comments:
1. Do you want to remove the unused field compactionpolicy from HStore.java
2. Do you want to retain the existing signature for createComponents and instead have the
method throw RuntimeException (which doesn't need to be declared).
3. Javadoc in StoreEngine needs to be updated to reflect the signature (e.g. getCompactionPolicy)
4. I am confused by the "isInitialized" field in the StoreEngine.java that you removed in
the patch. Why was that required earlier and not required now?
                
> make policy and compactor in default store engine separately pluggable (for things like
tier-based, and default policy experiments with permutations)
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7935
>                 URL: https://issues.apache.org/jira/browse/HBASE-7935
>             Project: HBase
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HBASE-7935-v0.patch, HBASE-7935-v0-with-7843.patch, HBASE-7935-v1.patch,
HBASE-7935-v2.patch
>
>
> Technically, StoreEngine can be used to achieve any permutations of things, but to make
it more convenient to replace compaction policy/compator in standard schemes like tier-based,
we can add separate hooks in DefaultStoreEngine (as long as custom ones conform to its default
expectations e.g. flat list of sorted files, etc.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message