hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7845) optimize hfile index key
Date Fri, 08 Mar 2013 17:38:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597320#comment-13597320
] 

Ted Yu commented on HBASE-7845:
-------------------------------

I ran the failed tests and they passed locally.
{code}
+        throw new IOException("Unexpected getFakedKey result, fakeKey:" +
+      fakeKey + ", firstKeyInBlock:" + firstKeyInBlock);
{code}
Indentation is off.
{code}
+    Bytes.equals(newKey, KeyValue.ROW_LENGTH_SIZE, newRowLength, expectedArray, 0,
+      expectedArray.length);
+    //verify: same with "row + family + qualifier", return rightKey directly
{code}
Style: please leave a blank line above the comment in test.
{code}
+    public byte[] getFakedKey(final byte[] leftKey, final byte[] rightKey) {
+      return Arrays.copyOf(rightKey, rightKey.length);
+    }
{code}
Add @Override to above method.


                
> optimize hfile index key
> ------------------------
>
>                 Key: HBASE-7845
>                 URL: https://issues.apache.org/jira/browse/HBASE-7845
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile
>    Affects Versions: 0.96.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>             Fix For: 0.98.0
>
>         Attachments: HBASE-7845.txt, HBASE-7845-v2.txt, HBASE-7845-v3.txt, HBASE-7845-v4.txt,
HBASE-7845-v5.txt
>
>
> Leveldb uses ByteWiseComparatorImpl::FindShortestSeparator() & FindShortSuccessor()
to reduce index key size, it would be helpful under special conditions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message