hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7679) implement store file management for stripe compactions
Date Mon, 18 Mar 2013 20:13:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605572#comment-13605572
] 

Sergey Shelukhin commented on HBASE-7679:
-----------------------------------------

bq. ConcatenatedLists should have unit test.
Added.

bq. Should this define be in the Interface or do you think it implementation specific?
bq. + public static final String BLOCKING_STOREFILES_KEY = "hbase.hstore.blockingStoreFiles";
Not certain, having things in HStore seems to be the convention. Store isn't a "real" interface
that invites different implementation :)

bq. On StripeStoreFileManager, do we know if this approach has merit? Have we run models or
actual test runs and can see it saves i/o? Would be interesting to know. Do we have to commit
it to figure this out? I can see committing all the refactorings which allow different compaction
policies but would think a compaction engine would need to have proven merit before it goes
in? What you think Sergey?
I have an integration test in HBASE-8000, but have only run it for correctness now.
I plan to make a bigger test for perf, and move to commit after having some numbers.

bq. Do we have to have a L0? Can we not flush multiple files when we flush, one per boundary
in the region? Was that thought just too much work flushing?
I was concerned about many small files, and scope creep into memstore, as discussed.
Let me do a write-up on this (probably useful anyway), and discuss on dev list.
After integration tests on tiny files (not a target scenario for this, but still), I wonder
if impact of L0 files on # of files to be read for gets is indeed worth it.
On the other hand for scans, and for overall situation large number of small files is not
good.


                
> implement store file management for stripe compactions
> ------------------------------------------------------
>
>                 Key: HBASE-7679
>                 URL: https://issues.apache.org/jira/browse/HBASE-7679
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7667-and-7603-v0-incomplete.patch, HBASE-7667-and-7603-v0-incomplete.patch,
HBASE-7667-and-7603-v1.patch, HBASE-7667-and-7603-v1.patch, HBASE-7667-v1.patch, HBASE-7667-v1.patch,
HBASE-7667-v2.patch, HBASE-7667-v2.patch, HBASE-7667-v3.patch, HBASE-7679-v4.patch, HBASE-7679-v5.patch,
HBASE-7679-v6.patch, HBASE-7679-v7-.patch, HBASE-7679-v7.patch, HBASE-7679-v8.patch, HBASE-7679-v9.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message