hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gustavo Anatoly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
Date Sat, 02 Mar 2013 01:43:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591197#comment-13591197

Gustavo Anatoly commented on HBASE-7462:

Hi, Stack.

Let me try explain better, when serverManager.addServerToDrainList(SERVERNAME_A) is called
this server cannot be used to compose a region plan, my doubt is: When called AM#RegionStates#regionOnline(SERVERNAME_A,
REGION_INFO), I was thinking that SERVERNAME_A should not be allowed, in this process to put
this region online. 

am.assign(REGION_INFO, false);
am.getRegionStates().isRegionAssigned(REGION_INFO); // Should be false here?

Sorry, if my previous question did not have sense, I have a lot to learn, and correct me if
I wrong.

Thanks, for help.

> TestDrainingServer is an integration test. It should be a unit test instead
> ---------------------------------------------------------------------------
>                 Key: HBASE-7462
>                 URL: https://issues.apache.org/jira/browse/HBASE-7462
>             Project: HBase
>          Issue Type: Wish
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Priority: Trivial
>              Labels: noob
> TestDrainingServer tests the function that allows to say that a regionserver should not
get new regions.
> As it is written today, it's an integration test: it starts & stops a cluster.
> The test would be more efficient if it would just check that the AssignmentManager does
not use the drained region server; whatever the circumstances (bulk assign or not for example).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message