hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-7255) KV size metric went missing from StoreScanner.
Date Mon, 18 Mar 2013 23:23:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605790#comment-13605790
] 

Ted Yu edited comment on HBASE-7255 at 3/18/13 11:23 PM:
---------------------------------------------------------

If I understand the current implementation correctly, a MetricsStoreSource should be added
under hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver and implementations
would be added under:

./hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreSourceImpl.java
./hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreSourceImpl.java
                
      was (Author: yuzhihong@gmail.com):
    If I understand the current implementation correctly, a MetricsStoreSource should be added
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver and implementations
would be added:

./hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreSourceImpl.java
./hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreSourceImpl.java
                  
> KV size metric went missing from StoreScanner.
> ----------------------------------------------
>
>                 Key: HBASE-7255
>                 URL: https://issues.apache.org/jira/browse/HBASE-7255
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Elliott Clark
>            Priority: Critical
>             Fix For: 0.95.0
>
>
> In trunk due to the metric refactor, at least the KV size metric went missing.
> See this code in StoreScanner.java:
> {code}
>     } finally {
>       if (cumulativeMetric > 0 && metric != null) {
>       }
>     }
> {code}
> Just an empty if statement, where the metric used to be collected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message