Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 28 Feb 2013 01:36:12 +0000 (UTC)
From: "Raymond Liu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12634370.1361951696427.354706.1362015372012@arcas>
In-Reply-To: <JIRA.12634370.1361951696427@arcas>
References: <JIRA.12634370.1361951696427@arcas>
Subject: [jira] [Commented] (HBASE-7952) Remove update() and Improve
 ExplicitColumnTracker performance.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589016#comment-13589016 ] 

Raymond Liu commented on HBASE-7952:
------------------------------------

Thanks for review, Ted, Sergey.

Patch updated for the javadoc warnings.

btw. Ted, I am curious how did you find the javadoc warnings in the Test results?  I search through the testReport generated above. could not find these lines. What's the proper way to located them by myself from the generated test report?

                
> Remove update() and Improve ExplicitColumnTracker performance.
> --------------------------------------------------------------
>
>                 Key: HBASE-7952
>                 URL: https://issues.apache.org/jira/browse/HBASE-7952
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.94.1, 0.94.5
>            Reporter: Raymond Liu
>            Assignee: Raymond Liu
>             Fix For: 0.96.0
>
>         Attachments: HBASE_7952.patch
>
>
> In ColumnTracker.java, the update() method is not used by anyone now. And no one will call checkColumn for different HFiles with update() in between files to re-walk through the target columns. All columns will be feed to checkColumn() in order.
> So, within ExplicitColumnTracker, the target columns can be optimized to not dynamic maintain a changing list of columns yet to match. Instead, just move index through it is enough.
> with this optimization to save the time for avoid reconstruct a columns array upon each row, the checkColumn method's performance could be improved by 10-20%.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira