Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 14F4DED42 for ; Thu, 28 Feb 2013 00:09:15 +0000 (UTC) Received: (qmail 5547 invoked by uid 500); 28 Feb 2013 00:09:14 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 5510 invoked by uid 500); 28 Feb 2013 00:09:14 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 5501 invoked by uid 99); 28 Feb 2013 00:09:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Feb 2013 00:09:14 +0000 Date: Thu, 28 Feb 2013 00:09:14 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7944) Replication leaks file reader resource & not reset currentNbOperations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588945#comment-13588945 ] Hudson commented on HBASE-7944: ------------------------------- Integrated in hbase-0.95 #6 (See [https://builds.apache.org/job/hbase-0.95/6/]) HBASE-7944 Replication leaks file reader resource & not reset currentNbOperations (Jeffrey Zhong) (Revision 1450902) Result = FAILURE tedyu : Files : * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationHLogReaderManager.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java > Replication leaks file reader resource & not reset currentNbOperations > ---------------------------------------------------------------------- > > Key: HBASE-7944 > URL: https://issues.apache.org/jira/browse/HBASE-7944 > Project: HBase > Issue Type: Sub-task > Reporter: Jeffrey Zhong > Assignee: Jeffrey Zhong > Fix For: 0.95.0, 0.98.0 > > Attachments: 0.94.patch, hbase-7944.patch > > > When I trace test case TestReplicationQueueFailover, I found current replication logic has two following issues: > 1) leak file reader when finishing read a file in function finishCurrentFile > 2) never reset currentNbOperations(this can be seen in the attached error log) such as "currentNbOperations:12655 and seenEntries:0 and size: 0" inconsistant info. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira