Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 27 Feb 2013 01:11:12 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12632989.1361283508074.346907.1361927472105@arcas>
In-Reply-To: <JIRA.12632989.1361283508074@arcas>
References: <JIRA.12632989.1361283508074@arcas>
Subject: [jira] [Updated] (HBASE-7878) recoverFileLease does not check
 return value of recoverLease
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-7878:
--------------------------

    Attachment: 7878-trunk-v5.txt

Patch v5 introduced FSHDFSUtils.TEST_TRIGGER_DFS_APPEND as described earlier.

I also made testAppendClose() execute both code paths:
1. recoverLease() is called - this would succeed on the first call
2. fs.append() is called, triggered directly by the new conf parameter.

recoverLease() passes using hadoop 1.0

Comments are welcome
                
> recoverFileLease does not check return value of recoverLease
> ------------------------------------------------------------
>
>                 Key: HBASE-7878
>                 URL: https://issues.apache.org/jira/browse/HBASE-7878
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.95.0, 0.94.6
>            Reporter: Eric Newton
>            Assignee: Ted Yu
>            Priority: Critical
>             Fix For: 0.95.0, 0.94.6
>
>         Attachments: 7878-trunk-v2.txt, 7878-trunk-v3.txt, 7878-trunk-v4.txt, 7878-trunk-v5.txt
>
>
> I think this is a problem, so I'm opening a ticket so an HBase person takes a look.
> Apache Accumulo has moved its write-ahead log to HDFS. I modeled the lease recovery for Accumulo after HBase's lease recovery.  During testing, we experienced data loss.  I found it is necessary to wait until recoverLease returns true to know that the file has been truly closed.  In FSHDFSUtils, the return result of recoverLease is not checked. In the unit tests created to check lease recovery in HBASE-2645, the return result of recoverLease is always checked.
> I think FSHDFSUtils should be modified to check the return result, and wait until it returns true.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira