Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 23 Feb 2013 17:42:13 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12631299.1360254569207.328632.1361641333024@arcas>
In-Reply-To: <JIRA.12631299.1360254569207@arcas>
References: <JIRA.12631299.1360254569207@arcas>
Subject: [jira] [Commented] (HBASE-7790) Refactor OpenRegionHandler so that
 the cleanup happens in one place - the finally block
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585174#comment-13585174 ] 

ramkrishna.s.vasudevan commented on HBASE-7790:
-----------------------------------------------

Ted, if i get you correctly you mean like move the 
{code}
final Boolean current = this.rsServices.getRegionsInTransitionInRS().
           remove(this.regionInfo.getEncodedNameAsBytes());
 
{code}
inside else block?
If this understanding of mine is right, then i think the removal of the RIT should be done in any case.  Hence i kept it in a common place.  Also wanted the cleanup to happen and then removal should happen.  Else the test case in TestRegionServerNoMaster  fails.  And it is correct behaviour too.
The code inside if openSuccessfule = true is just for logging to understand what happened during opening.  

                
> Refactor OpenRegionHandler so that the cleanup happens in one place - the finally block
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-7790
>                 URL: https://issues.apache.org/jira/browse/HBASE-7790
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7790.patch
>
>
> This is based on discussion in HBASE-7698.  Jimmy suggested this improvment.
> Look at 
> https://issues.apache.org/jira/browse/HBASE-7698?focusedCommentId=13572736&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13572736

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira