Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BAB75EF24 for ; Thu, 7 Feb 2013 17:43:13 +0000 (UTC) Received: (qmail 98627 invoked by uid 500); 7 Feb 2013 17:43:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 98579 invoked by uid 500); 7 Feb 2013 17:43:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 98427 invoked by uid 99); 7 Feb 2013 17:43:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Feb 2013 17:43:13 +0000 Date: Thu, 7 Feb 2013 17:43:13 +0000 (UTC) From: "Sergey Shelukhin (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7786) Consolidate HRegion creation/opening API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573703#comment-13573703 ] Sergey Shelukhin commented on HBASE-7786: ----------------------------------------- ...assuming the tests pass :) > Consolidate HRegion creation/opening API > ---------------------------------------- > > Key: HBASE-7786 > URL: https://issues.apache.org/jira/browse/HBASE-7786 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.96.0 > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Attachments: HBASE-7786-v0.patch, HBASE-7786-v1.patch > > > Currently we have 4 ways to instantiate an HRegion. > * HRegion.createHRegion() > * HRegion.openHRegion() > * HRegion.newHRegion() + r.initialize() > * new HRegion() + r.initialize() > Aside from tests and HMerge and SplitTransaction code everyone use createHRegion() and openHRegion(). To avoid errors due to missing initialization calls I think we should limit the access to newHRegion() and the constructor. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira