Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 35450E5A0 for ; Tue, 5 Feb 2013 15:09:15 +0000 (UTC) Received: (qmail 22500 invoked by uid 500); 5 Feb 2013 15:09:15 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 22405 invoked by uid 500); 5 Feb 2013 15:09:14 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 22278 invoked by uid 99); 5 Feb 2013 15:09:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Feb 2013 15:09:13 +0000 Date: Tue, 5 Feb 2013 15:09:13 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7756) Strange code in ServerCallable#shouldRetry MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571368#comment-13571368 ] Hudson commented on HBASE-7756: ------------------------------- Integrated in HBase-TRUNK #3851 (See [https://builds.apache.org/job/HBase-TRUNK/3851/]) HBASE-7756 Strange code in ServerCallable#shouldRetry (Revision 1442560) Result = FAILURE nkeywal : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java > Strange code in ServerCallable#shouldRetry > ------------------------------------------ > > Key: HBASE-7756 > URL: https://issues.apache.org/jira/browse/HBASE-7756 > Project: HBase > Issue Type: Bug > Components: Client > Affects Versions: 0.96.0, 0.94.4 > Reporter: nkeywal > Assignee: nkeywal > Fix For: 0.96.0 > > Attachments: 7756.v1.patch, 7756.v2.patch > > > This code is strange. > If you configure a different value for HBASE_CLIENT_OPERATION_TIMEOUT, you can have only one socket timeout (whatever your setting for the socket timeout). If not, the first time we will retry (again, whatever your setting and the real timeout). > {code} > public void shouldRetry(Throwable throwable) throws IOException { > if (this.callTimeout != HConstants.DEFAULT_HBASE_CLIENT_OPERATION_TIMEOUT) > if (throwable instanceof SocketTimeoutException > || (this.endTime - this.startTime > this.callTimeout)) { > throw (SocketTimeoutException) new SocketTimeoutException( > "Call to access row '" + Bytes.toString(row) + "' on table '" > + Bytes.toString(tableName) > + "' failed on socket timeout exception: " + throwable + " this.callTimeout="+this.callTimeout + " time= "+(this.endTime - this.startTime)) > .initCause(throwable); > } else { > this.callTimeout = ((int) (this.endTime - this.startTime)); > } > } > {code} > I don't get all the implications yet, but for sure it's too smart to be good, and, at least, breaks my tests for HBASE-7590 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira