Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2DCD2E978 for ; Sat, 23 Feb 2013 00:10:13 +0000 (UTC) Received: (qmail 95890 invoked by uid 500); 23 Feb 2013 00:10:12 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 95854 invoked by uid 500); 23 Feb 2013 00:10:12 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95845 invoked by uid 99); 23 Feb 2013 00:10:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Feb 2013 00:10:12 +0000 Date: Sat, 23 Feb 2013 00:10:12 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7649) client retry timeout doesn't need to do x2 fallback when going to different server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584856#comment-13584856 ] Ted Yu commented on HBASE-7649: ------------------------------- {code} +public class HRegionCacheLocation extends HRegionLocation { {code} Add javadoc for the class along with annotation for audience. For checkIfOpenGracePeriodExpired(): {code} + if (openingTime == null) { + openingTime = now; + return false; {code} When would user call checkIfOpenGracePeriodExpired() before setting openingTime ? One question is about the type of openingTime field. Method parameters are all long. Does the field have to be Long ? For NotServingRegionException.java, is the following import needed ? {code} +import org.apache.hadoop.ipc.RemoteException; {code} {code} + public static final String RETRIES_BY_SERVER = "hbase.client.retries.by.server"; {code} To signify that the config key carries a boolean value, can it be named "hbase.client.retries.byserver.enable" ? {code} + public static final String SERVER_OPEN_REGION_GRACE_PERIOD + = "hbase.client.retries.openregion.graceperiod"; + public static final Long DEFAULT_SERVER_OPEN_REGION_GRACE_PERIOD = 10000L; {code} The above constants can be private. For HRegionServer.java : {code} + if (isOpening != null && isOpening.booleanValue()) { + throw new RegionOpeningException("Region is being opened: " + encodedRegionName); + } else { {code} nit: the 'else' is not needed. > client retry timeout doesn't need to do x2 fallback when going to different server > ---------------------------------------------------------------------------------- > > Key: HBASE-7649 > URL: https://issues.apache.org/jira/browse/HBASE-7649 > Project: HBase > Issue Type: Improvement > Components: Client > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Attachments: HBASE-7649-v0.patch, HBASE-7649-v1.patch, HBASE-7649-v2.patch, HBASE-7649-v2.patch, HBASE-7649-v2.patch, HBASE-7649-v3.patch, HBASE-7649-v4.patch, HBASE-7649-v5.patch > > > See HBASE-7520. When we go to server A, get a bunch of failures, then finally learn the region is on B it doesn't make sense to wait for 30 seconds before going to B. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira