Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 513DEEF31 for ; Thu, 28 Feb 2013 05:29:24 +0000 (UTC) Received: (qmail 17266 invoked by uid 500); 28 Feb 2013 05:29:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 17215 invoked by uid 500); 28 Feb 2013 05:29:23 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 17189 invoked by uid 99); 28 Feb 2013 05:29:23 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Feb 2013 05:29:23 +0000 Date: Thu, 28 Feb 2013 05:29:23 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7114) Increment does not extend Mutation but probably should MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589214#comment-13589214 ] Hudson commented on HBASE-7114: ------------------------------- Integrated in hbase-0.95-on-hadoop2 #3 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/3/]) HBASE-7114 Increment does not extend Mutation but probably should (Revision 1450933) Result = FAILURE stack : Files : * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * /hbase/branches/0.95/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestIncrement.java > Increment does not extend Mutation but probably should > ------------------------------------------------------ > > Key: HBASE-7114 > URL: https://issues.apache.org/jira/browse/HBASE-7114 > Project: HBase > Issue Type: Bug > Components: Client > Reporter: Andrew Purtell > Assignee: stack > Priority: Critical > Fix For: 0.95.0, 0.98.0 > > Attachments: 7114.txt, 7114v2.txt, 7114v3.txt, 7114v4.txt, 7115v5.txt > > > Increment is the only operation in the class of mutators that does not extend Mutation. It mostly duplicates what Mutation provides, but not quite. The signatures for setWriteToWAL and getFamilyMap are slightly different. This can be inconvenient because it requires special case code and therefore could be considered an API design nit. Unfortunately it is not a simple change: The interface is marked stable and the internals of the family map are different from other mutation types. The latter is why I suspect this was not addressed when Mutation was introduced. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira