Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 27 Feb 2013 07:33:15 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12615206.1352312396224.348836.1361950395656@arcas>
In-Reply-To: <JIRA.12615206.1352312396224@arcas>
References: <JIRA.12615206.1352312396224@arcas>
Subject: [jira] [Commented] (HBASE-7114) Increment does not extend Mutation
 but probably should
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588085#comment-13588085 ] 

Hadoop QA commented on HBASE-7114:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12571153/7114v3.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4571//console

This message is automatically generated.
                
> Increment does not extend Mutation but probably should
> ------------------------------------------------------
>
>                 Key: HBASE-7114
>                 URL: https://issues.apache.org/jira/browse/HBASE-7114
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Andrew Purtell
>            Assignee: stack
>            Priority: Critical
>             Fix For: 0.95.0
>
>         Attachments: 7114.txt, 7114v2.txt, 7114v3.txt
>
>
> Increment is the only operation in the class of mutators that does not extend Mutation. It mostly duplicates what Mutation provides, but not quite. The signatures for setWriteToWAL and getFamilyMap are slightly different. This can be inconvenient because it requires special case code and therefore could be considered an API design nit. Unfortunately it is not a simple change: The interface is marked stable and the internals of the family map are different from other mutation types. The latter is why I suspect this was not addressed when Mutation was introduced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira