Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44E9FEA61 for ; Sun, 24 Feb 2013 04:50:17 +0000 (UTC) Received: (qmail 89256 invoked by uid 500); 24 Feb 2013 04:50:17 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 88940 invoked by uid 500); 24 Feb 2013 04:50:16 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 87795 invoked by uid 99); 24 Feb 2013 04:50:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Feb 2013 04:50:14 +0000 Date: Sun, 24 Feb 2013 04:50:14 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-7114) Increment does not extend Mutation but probably should MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-7114: ------------------------- Priority: Critical (was: Minor) Marking critical so we don't forget. The setWriteToWAL stuff here I don't see in current implementation of Increment. Was it removed? Meantime, hbase-7900 is making Increment implement Mutation so it 'fixes' this issue? (Ted brought this up over in rb on 7900 patch) > Increment does not extend Mutation but probably should > ------------------------------------------------------ > > Key: HBASE-7114 > URL: https://issues.apache.org/jira/browse/HBASE-7114 > Project: HBase > Issue Type: Bug > Components: Client > Affects Versions: 0.96.0 > Reporter: Andrew Purtell > Priority: Critical > > Increment is the only operation in the class of mutators that does not extend Mutation. It mostly duplicates what Mutation provides, but not quite. The signatures for setWriteToWAL and getFamilyMap are slightly different. This can be inconvenient because it requires special case code and therefore could be considered an API design nit. Unfortunately it is not a simple change: The interface is marked stable and the internals of the family map are different from other mutation types. The latter is why I suspect this was not addressed when Mutation was introduced. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira