hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7952) Remove update() and Improve ExplicitColumnTracker performance.
Date Thu, 28 Feb 2013 06:01:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589231#comment-13589231
] 

stack commented on HBASE-7952:
------------------------------

[~colorant] Is it not a javadoc warning.  It is this text: ' * Currently there are two different
types of Store/Family-level queries.' in ColumnTracker and a variant is repeated in the Explicit*.
 The text says two types but there is only one now because you are removing 'update', one
of the options, in this patch.

bq. Do you think we need to double check this in columnTracker?

Not if there are enough guards against this happening already.  Do you think there are?  What
are they?  Thanks [~colorant]

                
> Remove update() and Improve ExplicitColumnTracker performance.
> --------------------------------------------------------------
>
>                 Key: HBASE-7952
>                 URL: https://issues.apache.org/jira/browse/HBASE-7952
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.94.1, 0.94.5
>            Reporter: Raymond Liu
>            Assignee: Raymond Liu
>             Fix For: 0.96.0
>
>         Attachments: HBASE_7952.patch
>
>
> In ColumnTracker.java, the update() method is not used by anyone now. And no one will
call checkColumn for different HFiles with update() in between files to re-walk through the
target columns. All columns will be feed to checkColumn() in order.
> So, within ExplicitColumnTracker, the target columns can be optimized to not dynamic
maintain a changing list of columns yet to match. Instead, just move index through it is enough.
> with this optimization to save the time for avoid reconstruct a columns array upon each
row, the checkColumn method's performance could be improved by 10-20%.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message