hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7923) force unassign can confirm region online on any RS to get rid of double assignments.
Date Tue, 26 Feb 2013 21:04:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587547#comment-13587547
] 

stack commented on HBASE-7923:
------------------------------

It is force so do we need to do the unassign first?  I would not pass silently.  Would add
a log because else someone will think the call is not happening.  Good one.
                
> force unassign can confirm region online on any RS to get rid of double assignments.
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-7923
>                 URL: https://issues.apache.org/jira/browse/HBASE-7923
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>             Fix For: 0.95.0
>
>         Attachments: HBASE-7923.patch
>
>
> Presently in force unassign we are offlining a region from AM and reassigning it, which
may cause double assignments.
> {code}
>         this.assignmentManager.regionOffline(hri);
>         assignRegion(hri);
> {code}
> Any way if a region is not served by any RS we are offlining the region from AM. 
> {code}
>        if (t instanceof NotServingRegionException) {
>           if (transitionInZK) {
>             deleteClosingOrClosedNode(region);
>           }
>           regionOffline(region);
>           return;
>         } 
> {code}
> We can change as below just to confirm whether region online on any RS.
> {code}
> this.assignmentManager.unassign(hri,force);
> if(!this.assignmentManager.getRegionStates().isRegionInTransition(hri) && !this.assignmentManager.getRegionStates().isRegionAssigned(hri)
){
> 	assignRegion(hri);
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message