hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7919) Wrong key is used in ServerManager#getServerConnection() to retrieve from Map serverConnections
Date Sat, 23 Feb 2013 16:40:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585161#comment-13585161
] 

Anoop Sam John commented on HBASE-7919:
---------------------------------------

[~ram_krish] It is a straight forward issue and patch. That is why I thought tests not needed
:) Is it good to go with out patch? Else I will try..
                
> Wrong key is used in ServerManager#getServerConnection() to retrieve from Map serverConnections
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7919
>                 URL: https://issues.apache.org/jira/browse/HBASE-7919
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.94.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.94.6
>
>         Attachments: HBASE-7919_94.patch
>
>
> ServerManager#getServerConnection() try to retrieve the cached connection from Map serverConnections.
ServerName objects are the key with which items are saved in this map. But we use String type
to get. This always returns null and in turn the Master creates a new connection with RS again
and again.
> {code}
> private final Map<ServerName, HRegionInterface> serverConnections =
>     new HashMap<ServerName, HRegionInterface>();
> ...........
> private HRegionInterface getServerConnection(final ServerName sn)
>   throws IOException {
>     HRegionInterface hri = this.serverConnections.get(sn.toString());
>     if (hri == null) {
>       LOG.debug("New connection to " + sn.toString());
>       hri = this.connection.getHRegionConnection(sn.getHostname(), sn.getPort());
>       this.serverConnections.put(sn, hri);
>     }
>     return hri;
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message