hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-7888) Simplify logic of SnapshotManager#getCompletedSnapshots()
Date Wed, 20 Feb 2013 19:07:12 GMT

     [ https://issues.apache.org/jira/browse/HBASE-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated HBASE-7888:
--------------------------

    Summary: Simplify logic of SnapshotManager#getCompletedSnapshots()  (was: Simplify logic
of getCompletedSnapshots())
    
> Simplify logic of SnapshotManager#getCompletedSnapshots()
> ---------------------------------------------------------
>
>                 Key: HBASE-7888
>                 URL: https://issues.apache.org/jira/browse/HBASE-7888
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>
> This came up during code review of mega patch.
> isSnapshotCompleted() checks the existence of snapshotDir to see if the snapshot already
exists.
> getCompletedSnapshots(), on the other hand, reads SnapshotDescriptionUtils.SNAPSHOTINFO_FILE
for the same purpose.
> Since all the snapshot files are first created in a tmp dir and a rename is done to move
them into the .snapshots dir upon completion, logic in getCompletedSnapshots() can be simplified.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message