hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7878) recoverFileLease does not check return value of recoverLease
Date Thu, 28 Feb 2013 19:07:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589811#comment-13589811
] 

Ted Yu commented on HBASE-7878:
-------------------------------

I looked through https://builds.apache.org/job/PreCommit-HBASE-Build/4607/artifact/trunk/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.regionserver.wal.TestHLogSplitCompressed-output.txt
for logs from util.FSHDFSUtils():
{code}
2013-02-28 18:06:29,621 INFO  [pool-1-thread-1] hbase.ResourceChecker(147): before: regionserver.wal.TestHLogSplitCompressed#testSplitFailsIfNewHLogGetsCreatedAfterSplitStarted
Thread=71, OpenFileDescriptor=196, MaxFileDescriptor=60000, ConnectionCount=0
Cleaning up cluster for new test
...
2013-02-28 18:06:43,515 INFO  [pool-1-thread-1] util.FSHDFSUtils(72): Recovering file hdfs://localhost:58649/hbase/hlog/hlog.dat.0
2013-02-28 18:06:43,515 INFO  [pool-1-thread-1] util.FSHDFSUtils(137): Finished lease recover
attempt for hdfs://localhost:58649/hbase/hlog/hlog.dat.0
...
2013-02-28 18:06:44,141 INFO  [pool-1-thread-1] hbase.ResourceChecker(171): after: regionserver.wal.TestHLogSplitCompressed#testSplitFailsIfNewHLogGetsCreatedAfterSplitStarted
Thread=68 (was 71), OpenFileDescriptor=190 (was 196), MaxFileDescriptor=60000 (was 60000),
ConnectionCount=0 (was 0)
{code}
There was not clue in the above segment.

Will add more debug log in next patch.
                
> recoverFileLease does not check return value of recoverLease
> ------------------------------------------------------------
>
>                 Key: HBASE-7878
>                 URL: https://issues.apache.org/jira/browse/HBASE-7878
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.95.0, 0.94.6
>            Reporter: Eric Newton
>            Assignee: Ted Yu
>            Priority: Critical
>             Fix For: 0.95.0, 0.98.0, 0.94.7
>
>         Attachments: 7878.94, 7878-94.addendum, 7878-94.addendum2, 7878-trunk.addendum,
7878-trunk.addendum2, 7878-trunk-v2.txt, 7878-trunk-v3.txt, 7878-trunk-v4.txt, 7878-trunk-v5.txt,
7878-trunk-v6.txt
>
>
> I think this is a problem, so I'm opening a ticket so an HBase person takes a look.
> Apache Accumulo has moved its write-ahead log to HDFS. I modeled the lease recovery for
Accumulo after HBase's lease recovery.  During testing, we experienced data loss.  I found
it is necessary to wait until recoverLease returns true to know that the file has been truly
closed.  In FSHDFSUtils, the return result of recoverLease is not checked. In the unit tests
created to check lease recovery in HBASE-2645, the return result of recoverLease is always
checked.
> I think FSHDFSUtils should be modified to check the return result, and wait until it
returns true.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message