hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7878) recoverFileLease does not check return value of recoverLease
Date Tue, 26 Feb 2013 23:58:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587752#comment-13587752
] 

stack commented on HBASE-7878:
------------------------------

Sure.  This stuff is hard to test.  Whatever it takes.  You might add the test to elsewhere
in test code base where we ensure we recover all edits from a WAL; it would be a special case
where we went to append to get the edits instead.

I'm still not clear from [~umamaheswararao] comments above if recoverFileLease will flip to
returning true eventually.  File will not be closed.  That is the point of the recoverFileLease.
 File is opened by another process altogether and we want to assume the file after we've figured
the other process crashed.
                
> recoverFileLease does not check return value of recoverLease
> ------------------------------------------------------------
>
>                 Key: HBASE-7878
>                 URL: https://issues.apache.org/jira/browse/HBASE-7878
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.95.0, 0.94.6
>            Reporter: Eric Newton
>            Assignee: Ted Yu
>            Priority: Critical
>             Fix For: 0.95.0, 0.94.6
>
>         Attachments: 7878-trunk-v2.txt, 7878-trunk-v3.txt, 7878-trunk-v4.txt
>
>
> I think this is a problem, so I'm opening a ticket so an HBase person takes a look.
> Apache Accumulo has moved its write-ahead log to HDFS. I modeled the lease recovery for
Accumulo after HBase's lease recovery.  During testing, we experienced data loss.  I found
it is necessary to wait until recoverLease returns true to know that the file has been truly
closed.  In FSHDFSUtils, the return result of recoverLease is not checked. In the unit tests
created to check lease recovery in HBASE-2645, the return result of recoverLease is always
checked.
> I think FSHDFSUtils should be modified to check the return result, and wait until it
returns true.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message