hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7867) setPreallocSize is different with COMMENT in setupTestEnv in MiniZooKeeperCluster.java
Date Sun, 17 Feb 2013 09:39:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580154#comment-13580154
] 

Hadoop QA commented on HBASE-7867:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12569712/hbase-7867.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4452//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4452//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4452//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4452//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4452//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4452//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4452//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4452//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4452//console

This message is automatically generated.
                
> setPreallocSize is different with COMMENT in setupTestEnv in MiniZooKeeperCluster.java
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-7867
>                 URL: https://issues.apache.org/jira/browse/HBASE-7867
>             Project: HBase
>          Issue Type: Bug
>            Reporter: DaeMyung Kang
>            Priority: Trivial
>             Fix For: 0.96.0, 0.94.6
>
>         Attachments: hbase-7867.patch, hbase-7867.patch
>
>
> setupTestEnv() just sets 100 bytes not 100k bytes
> {code}
> private static void setupTestEnv() {
> // / XXX: From o.a.zk.t.ClientBaseprivate static void setupTestEnv() {
> // during the tests we run with 100K prealloc in the logs.
> // on windows systems prealloc of 64M was seen to take ~15seconds
> // resulting in test failure (client timeout on first session).
> // set env and directly in order to handle static init/gc issues
>   System.setProperty("zookeeper.preAllocSize", "100");
>   FileTxnLog.setPreallocSize(100);
> }
> {code}
> to reduce too many call padLogFile(), I think 100k is correct.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message