hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7858) cleanup before merging snapshots branch to trunk
Date Tue, 19 Feb 2013 19:47:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581560#comment-13581560
] 

Ted Yu commented on HBASE-7858:
-------------------------------

Looking at other methods which access this.handler, such as snapshotEnabledTable(), they're
declared synchronized.

getTakeSnapshotHandler() is called by isSnapshotDone() which is not synchronized, hence the
change.
                
> cleanup before merging snapshots branch to trunk
> ------------------------------------------------
>
>                 Key: HBASE-7858
>                 URL: https://issues.apache.org/jira/browse/HBASE-7858
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 7858-v1.txt, 7858-v2.txt, 7858-v3.txt, 7858-v4.txt, 7858-v5.txt,
7858-v6.txt, 7858-v7.txt, 7858-v8.txt
>
>
> There have been a lot of review comments from https://reviews.apache.org/r/9416
> Since our goal of merging snapshot feature to trunk would preserve revision history,
a separate JIRA is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message