hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7858) cleanup before merging snapshots branch to trunk
Date Fri, 15 Feb 2013 18:37:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579402#comment-13579402
] 

Jonathan Hsieh commented on HBASE-7858:
---------------------------------------

I disagree with the coproc rename.  

On create and delete table, the completion of the table creation or deletion has a coproc
hook called postCreateTableHandler and postDeleteTableHandler.  So, let's keep the snapshot
ones as-is but when we add snapshot completion coproc hooks let's use the *Handler convention.

See
https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java#L50
                
> cleanup before merging snapshots branch to trunk
> ------------------------------------------------
>
>                 Key: HBASE-7858
>                 URL: https://issues.apache.org/jira/browse/HBASE-7858
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 7858-v1.txt
>
>
> There have been a lot of review comments from https://reviews.apache.org/r/9416
> Since our goal of merging snapshot feature to trunk would preserve revision history,
a separate JIRA is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message