hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7845) optimize hfile index key
Date Wed, 27 Feb 2013 03:15:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587953#comment-13587953
] 

Ted Yu commented on HBASE-7845:
-------------------------------

Took a brief look over the patch.
{code}
+      dataBlockIndexWriter.addEntry(shortestSeparator, lastDataBlockOffset,onDiskSize);
+    } else {
+      dataBlockIndexWriter.addEntry(firstKeyInBlock, lastDataBlockOffset,onDiskSize);
{code}
How would the above affect existing HFilev2 ?

I would expect a bump in minor version, at least.
                
> optimize hfile index key
> ------------------------
>
>                 Key: HBASE-7845
>                 URL: https://issues.apache.org/jira/browse/HBASE-7845
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile
>    Affects Versions: 0.96.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>         Attachments: HBASE-7845.txt, HBASE-7845-v2.txt
>
>
> Leveldb uses ByteWiseComparatorImpl::FindShortestSeparator() & FindShortSuccessor()
to reduce index key size, it would be helpful under special conditions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message