hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7843) enable encapsulating compaction policy/compactor/store file manager interaction shennanigans
Date Fri, 22 Feb 2013 03:14:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583863#comment-13583863
] 

Hadoop QA commented on HBASE-7843:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12570405/HBASE-7843-v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 13 new or modified
tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4493//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4493//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4493//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4493//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4493//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4493//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4493//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4493//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4493//console

This message is automatically generated.
                
> enable encapsulating compaction policy/compactor/store file manager interaction shennanigans
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7843
>                 URL: https://issues.apache.org/jira/browse/HBASE-7843
>             Project: HBase
>          Issue Type: Improvement
>          Components: Compaction
>    Affects Versions: 0.96.0
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7843-v0.patch, HBASE-7843-v1.patch
>
>
> To avoid massive casting and/or deciphering of structures traveling between SFM, compaction
policy, and compactor in non-trivial compaction schemes like stripe or level, we need to make
interaction between themselves hidden.
> Elsewhere, the changes are being made to coprocessor for compactions that will make CompactionRequest
a limited-visibility class for users, with coprocessors being able to subclass and return
it. -This seems like a viable solution for the problem at hand too. Policy will (optionally)
subclass compaction request and return it. Instead of calling something.compact(req), req.compact()
will be called (with "something" already stored inside req as of now), after which, magic
will happen.-
> After merging that code I actually see that subclassing compactionrequest in both will
break the policy, or require bunch of ugly code in coprocessors (a subclass for every policy,
and telling them apart.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message