hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
Date Fri, 22 Feb 2013 21:56:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584746#comment-13584746
] 

Sergey Shelukhin commented on HBASE-7791:
-----------------------------------------

bq. It should be increase by one?
Higher number means lower pri, so logically we reduce priority.

bq. But if really a compaction is USER requested then what is the priority. And even in that
case we increase the priority?
No, this happens only if the priority passed in is not user, see the surrounding "if"


                
> Compaction USER_PRIORITY is slightly broken
> -------------------------------------------
>
>                 Key: HBASE-7791
>                 URL: https://issues.apache.org/jira/browse/HBASE-7791
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HBASE-7791-v0.patch
>
>
> The code to get compaction priority is as such:
> {code}   public int getCompactPriority(int priority) {
>      // If this is a user-requested compaction, leave this at the highest priority
>      if(priority == Store.PRIORITY_USER) {
>        return Store.PRIORITY_USER;
>      } else {
>        return this.blockingStoreFileCount - this.storefiles.size();
>      }
>    }
> {code}.
> PRIORITY_USER is 1.
> The priorities are compared as numbers in HRegion, so compactions of blocking stores
will override user priority (probably intended); also, if you have blockingFiles minus one,
your priority is suddenly PRIORITY_USER, which may cause at least this:
>         LOG.debug("Warning, compacting more than " + comConf.getMaxFilesToCompact() +
>             " files because of a user-requested major compaction");
> as well as some misleading logging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message