hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7784) move the code related to selection that is specific to default compaction policy, into default compaction policy (from HStore)
Date Fri, 08 Feb 2013 17:41:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574658#comment-13574658
] 

Jimmy Xiang commented on HBASE-7784:
------------------------------------

I see.  I prefer to move this logic change/fix to HBASE-7791, and just do the refactory in
this one.  But it is ok.

You call it system compaction priority because it is not set by user? Why not just getCompactionPriority()?

{code}
+  @Override
+  public int getSystemCompactionPriority(final Collection<StoreFile> storeFiles) {
+    return this.comConf.getBlockingStorefileCount() - storeFiles.size();
+  }
{code}
                
> move the code related to selection that is specific to default compaction policy, into
default compaction policy (from HStore)
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7784
>                 URL: https://issues.apache.org/jira/browse/HBASE-7784
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: 7784-v0.patch, HBASE-7784-v0.patch
>
>
> There are some TODO [level compaction] in HBASE-7603 patch, there may also be few other
similar places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message