hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7725) Add generic attributes to CP initiated compaction request AND latch on compaction completion
Date Fri, 15 Feb 2013 04:11:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13578934#comment-13578934

Sergey Shelukhin commented on HBASE-7725:

I don't think I understand why we have to  make attributes visible to HBase code.
For example, when we call this:
            server.compactSplitThread.requestCompaction(region, store, "Recursive enqueue",
we are inside old CompactionRequest, so we could just pass "this" instead of attributes all
the way down, and coproc would get attributes if it needs to. That way HBase code doesn't
even have to know attributes exist inside coproc-subclasses CompactionRequest.
And coproc has to cast in this case anyway, either CR to subclass, or Object to specific attribute
But, this shouldn't be blocking, so +1
> Add generic attributes to CP initiated compaction request AND latch on compaction completion
> --------------------------------------------------------------------------------------------
>                 Key: HBASE-7725
>                 URL: https://issues.apache.org/jira/browse/HBASE-7725
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction, Coprocessors, regionserver
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.96.0, 0.94.6
>         Attachments: example.java, hbase-7725_0.94-v0.patch, hbase-7725-v0.patch, hbase-7725-v1.patch,
hbase-7725-v3.patch, hbase-7725_with-attributes-0.94-v0.patch, hbase-7725_with-attributes-0.94-v1.patch
> You can request that a compaction be started, but you can't be sure when that compaction
request completes. This is a simple update to the CompactionRequest interface and the compact-split
thread on the RS that doesn't actually impact the RS exposed interface.
> This is particularly useful for CPs so they can control starting/running a compaction.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message