hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7649) client retry timeout doesn't need to do x2 fallback when going to different server
Date Sat, 23 Feb 2013 00:10:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584856#comment-13584856

Ted Yu commented on HBASE-7649:

+public class HRegionCacheLocation extends HRegionLocation {
Add javadoc for the class along with annotation for audience.

For checkIfOpenGracePeriodExpired():
+    if (openingTime == null) {
+      openingTime = now;
+      return false;
When would user call checkIfOpenGracePeriodExpired() before setting openingTime ?

One question is about the type of openingTime field. Method parameters are all long. Does
the field have to be Long ?

For NotServingRegionException.java, is the following import needed ?
+import org.apache.hadoop.ipc.RemoteException;
+  public static final String RETRIES_BY_SERVER = "hbase.client.retries.by.server";
To signify that the config key carries a boolean value, can it be named "hbase.client.retries.byserver.enable"
+  public static final String SERVER_OPEN_REGION_GRACE_PERIOD
+    = "hbase.client.retries.openregion.graceperiod";
+  public static final Long DEFAULT_SERVER_OPEN_REGION_GRACE_PERIOD = 10000L;
The above constants can be private.

For HRegionServer.java :
+        if (isOpening != null && isOpening.booleanValue()) {
+          throw new RegionOpeningException("Region is being opened: " + encodedRegionName);
+        } else {
nit: the 'else' is not needed.
> client retry timeout doesn't need to do x2 fallback when going to different server
> ----------------------------------------------------------------------------------
>                 Key: HBASE-7649
>                 URL: https://issues.apache.org/jira/browse/HBASE-7649
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7649-v0.patch, HBASE-7649-v1.patch, HBASE-7649-v2.patch, HBASE-7649-v2.patch,
HBASE-7649-v2.patch, HBASE-7649-v3.patch, HBASE-7649-v4.patch, HBASE-7649-v5.patch
> See HBASE-7520. When we go to server A, get a bunch of failures, then finally learn the
region is on B it doesn't make sense to wait for 30 seconds before going to B.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message