hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj Das (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7641) Port HBASE-6669 'Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient' to trunk
Date Wed, 27 Feb 2013 22:01:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588833#comment-13588833
] 

Devaraj Das commented on HBASE-7641:
------------------------------------

Looks good overall. Some nits:
1. The methods getProtoForCellType and getProtoForPromotedType have very similar code. Maybe
have these methods call a common method?
2. There are unused imports in BigDecimalColumnInterpreter.java

+1 otherwise.
                
> Port HBASE-6669 'Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient'
to trunk
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7641
>                 URL: https://issues.apache.org/jira/browse/HBASE-7641
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Julian Wissmann
>              Labels: features, newbie, patch
>             Fix For: 0.95.0
>
>         Attachments: 7641v3.patch, BigDecimalColumnInterpreter.java, HBASE-7641.patch,
HBASE-7641v2.patch, hbase.proto, TestBigDecimalColumnInterpreter.java
>
>
> ColumnInterpreter implementation in trunk is different from that in 0.94
> This issue ports BigDecimalColumnInterpreter to trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message