hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7546) Obtain a table read lock on region split operations
Date Fri, 22 Feb 2013 00:48:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583755#comment-13583755
] 

Ted Yu commented on HBASE-7546:
-------------------------------

{code}
+      //acquire a shared read lock on the table, so that table schema modifications
+      //does not happen concurrently
{code}
'does not' -> 'do not'
{code}
+      } catch(IOException ex) {
{code}
nit: insert space after 'catch'
{code}
+      } catch (IOException ex) {
+        LOG.warn("Could not release the table lock", ex);
+        //TODO: if we get here, and not abort RS, this lock will never be released
{code}
What's your plan for above situation ?
{code}
+  // Table level lock manager for read locking for region operations
+  private TableLockManager tableLockManager;
{code}
The lock manager can also be used for write locking, right ?
                
> Obtain a table read lock on region split operations
> ---------------------------------------------------
>
>                 Key: HBASE-7546
>                 URL: https://issues.apache.org/jira/browse/HBASE-7546
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>         Attachments: hbase-7546_v1.patch, hbase-7546_v2.patch
>
>
> As discussed in the parent issue HBASE-7305, we should be coordinating between splits
and table operations to ensure that they don't happen at the same time. In this issue we will
acquire shared read locks for region splits. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message