hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7521) fix HBASE-6060 (regions stuck in opening state) in 0.94
Date Mon, 11 Feb 2013 20:19:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576083#comment-13576083
] 

Jimmy Xiang commented on HBASE-7521:
------------------------------------

@Ram, sure. I am ok with getting this to 0.94. I was just in doubt this will fix all racing
issues.  For example, the following code (in #assign) is synchronized on the regionstate.
 However, AM#handleRegion is synchronized on regionsInTransition.  Suppose serverManager.sendRegionOpen
returns RegionOpeningState.OPENED, but OpenRegionHandler fails to open it and transitions
the ZK node to RS_ZK_REGION_FAILED_OPEN, then handleRegion will transition the region state
to Closed, right after that, this thread transitions the state back to PENDING_OPEN, which
may cause some confusion further down the road.

{code}
+        RegionOpeningState regionOpenState = serverManager.sendRegionOpen(plan.getDestination(),
+            state.getRegion(), versionOfOfflineNode);
+        if (regionOpenState == RegionOpeningState.OPENED) {
+          // Transition RegionState to PENDING_OPEN
+          if (state.isOffline() && !state.isOpening()) {
+            state.update(RegionState.State.PENDING_OPEN,
+                System.currentTimeMillis(), plan.getDestination());
+          }
{code}

                
> fix HBASE-6060 (regions stuck in opening state) in 0.94
> -------------------------------------------------------
>
>                 Key: HBASE-7521
>                 URL: https://issues.apache.org/jira/browse/HBASE-7521
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.94.6
>
>         Attachments: 7521-original-patch-ported-v4.patch, HBASE-7521-original-patch-ported-v0.patch,
HBASE-7521-original-patch-ported-v1.patch, HBASE-7521-original-patch-ported-v2.patch, HBASE-7521-original-patch-ported-v3.patch,
HBASE-7521-v0.patch, HBASE-7521-v1.patch, HBASE-7521-v5.patch
>
>
> Discussion in HBASE-6060 implies that the fix there does not work on 0.94. Still, we
may want to fix the issue in 0.94 (via some different fix) because the regions stuck in opening
for ridiculous amounts of time is not a good thing to have.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message