hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7521) fix HBASE-6060 (regions stuck in opening state) in 0.94
Date Mon, 11 Feb 2013 17:33:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575919#comment-13575919
] 

ramkrishna.s.vasudevan commented on HBASE-7521:
-----------------------------------------------

{code}
if ((state.getServerName() != null) && state.getServerName().equals(sn)) {
{code}

This new change has been added because when in OFFLINE state we don't populate the servername
right?
{code}
+ ", which we are already trying to " + " ,which we are already trying to "
{code}
This msg is coming twice.
{code}
try {
      addRegionsInTransition(region, CLOSE);
    } catch (RegionAlreadyInTransitionException rate) {
      LOG.warn("Received close for region we are already opening or closing; "
          + region.getEncodedName());
      return false;
    }
{code}
Can we throw the exception instead of catching it as in openRegion()?

Rest looks the same.
@Jimmy
Prior to your changes in Trunk wrt to AM things were messy.  But i feel that if we get it
in atleast the problem addressed by this JIRA is solved.  There may be some issues hiding
some where but the issue addressed here is pretty much big.
Sergey's integration suite is a good one that tries to catch up many corner cases.  I am +1
on getting this to 0.94.

                
> fix HBASE-6060 (regions stuck in opening state) in 0.94
> -------------------------------------------------------
>
>                 Key: HBASE-7521
>                 URL: https://issues.apache.org/jira/browse/HBASE-7521
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.94.6
>
>         Attachments: HBASE-7521-original-patch-ported-v0.patch, HBASE-7521-original-patch-ported-v1.patch,
HBASE-7521-original-patch-ported-v2.patch, HBASE-7521-original-patch-ported-v3.patch, HBASE-7521-v0.patch,
HBASE-7521-v1.patch
>
>
> Discussion in HBASE-6060 implies that the fix there does not work on 0.94. Still, we
may want to fix the issue in 0.94 (via some different fix) because the regions stuck in opening
for ridiculous amounts of time is not a good thing to have.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message