hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7360) Snapshot 0.94 Backport
Date Thu, 28 Feb 2013 19:43:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589854#comment-13589854
] 

Jonathan Hsieh commented on HBASE-7360:
---------------------------------------

bq. and why the shell is still list_snapshots and admin is getCompletedSnapshots()?

The shell command to get the list of tables is 'list', so in the shell it make sense to keep
it as 'list_snapshots'

In the HBaseAdmin code there is a method called 'getTableDescriptors'.  The change Ted did
with 'getCompletedSnapshots' seems to go well with the latter.  

I just looked at the code again, and HBaseAdmin has another method called 'listTables' https://github.com/apache/hbase/blob/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java#L262
which is more analogous.  Since 0.95 isn't released yet, I'm fine if we revert to the 'listSnapshots'
name.

With this extra piece of evidence I'm leaning towards [~mbertozzi]'s suggestion of using the
listSnapshots name.

                
> Snapshot 0.94 Backport 
> -----------------------
>
>                 Key: HBASE-7360
>                 URL: https://issues.apache.org/jira/browse/HBASE-7360
>             Project: HBase
>          Issue Type: New Feature
>          Components: snapshots
>    Affects Versions: 0.94.3
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: 0.94.7
>
>         Attachments: HBASE-7360-v0.patch
>
>
> Backport snapshot code to 0.94
> The main changes needed to backport the snapshot are related to the protobuf vs writable
rpc.
> Offline Snapshot
>  * HBASE-6610 - HFileLink: Hardlink alternative for snapshot restore
>  * HBASE-6765 - Take a Snapshot interface
>  * HBASE-6571 - Generic multi-thread/cross-process error handling framework
>  * HBASE-6353 - Snapshots shell
>  * HBASE-7107 - Snapshot References Utils (FileSystem Visitor)
>  * HBASE-6863 - Offline snapshots
>  * HBASE-6865 - Snapshot File Cleaners
>  * HBASE-6777 - Snapshot Restore Interface
>  * HBASE-6230 - Clone/Restore Snapshots
>  * HBASE-6802 - Export Snapshot

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message