hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6493) HashSet of byte array is being used in couple of places
Date Thu, 21 Feb 2013 03:26:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582866#comment-13582866

Hadoop QA commented on HBASE-6493:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 7 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4477//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4477//console

This message is automatically generated.
> HashSet of byte array is being used in couple of places
> -------------------------------------------------------
>                 Key: HBASE-6493
>                 URL: https://issues.apache.org/jira/browse/HBASE-6493
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Shrijeet Paliwal
>            Assignee: Nick Dimiduk
>            Priority: Minor
>             Fix For: 0.96.0
>         Attachments: 0001-HBASE-6493-Use-custom-comparator-for-Set-byte.patch, 0001-HBASE-6493-Use-custom-comparator-for-Set-byte.patch
> While working on a jira I realized I had made a mistake of making a HashSet of byte array.

> Then out of curiosity I checked if we do same any where else in code base. I came with
following files. 
> # /src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java:    Set<byte []>
qualifiers = new HashSet<byte[]>();
> # /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:        columnFamilies
= new HashSet<byte[]>();
> # /src/test/java/org/apache/hadoop/hbase/filter/TestFirstKeyValueMatchingQualifiersFilter.java:
   Set<byte[]> quals = new HashSet<byte[]>();
> # /src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java:
   Set<byte[]> families = new HashSet<byte[]>();
> (1) and (3) are mine and I will fix them (not yet committed). Quoting the exact reference
from (2) below :
> {code}
>  @Override                                                                     
>   public GetStoreFileResponse getStoreFile(final RpcController controller,          
>       final GetStoreFileRequest request) throws ServiceException {              
>     try {                                                                       
>       HRegion region = getRegion(request.getRegion());                          
>       requestCount.incrementAndGet();                                           
>       Set<byte[]> columnFamilies = null;                                      
>       if (request.getFamilyCount() == 0) {                                      
>         columnFamilies = region.getStores().keySet();                           
>       } else {                                                                  
>         columnFamilies = new HashSet<byte[]>();                               
>         for (ByteString cf: request.getFamilyList()) {                          
>           columnFamilies.add(cf.toByteArray());                                 
>         }                                                                       
>       }  
> {code}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message