hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guido Serra aka Zeph (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5694) getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly
Date Fri, 22 Feb 2013 17:32:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584468#comment-13584468
] 

Guido Serra aka Zeph commented on HBASE-5694:
---------------------------------------------

argh... leave it... all of this is just WRONG...
{code}
          if (tScan.isSetTimestamp()) {
              scan.setTimeRange(Long.MIN_VALUE, tScan.getTimestamp());              
          }
{code}

instead of exposing the setTimeRange on the Thrift interface someone decided to hide it this
way
                
> getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5694
>                 URL: https://issues.apache.org/jira/browse/HBASE-5694
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>    Affects Versions: 0.92.1
>            Reporter: Wouter Bolsterlee
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5694.patch, HBASE-5694-trunk-20120402.patch, setTimestamp.patch
>
>
> The getRowsWithColumnsTs() method in the Thrift interface only applies the timestamp
if columns are explicitly specified. However, this method also allows for columns to be unspecified
(this is even used internally to implement e.g. getRows()). The cause of the bug is a minor
scoping issue: the time range is set inside a wrong if statement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message